-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(react-router): Add support for Hydrogen with RR7 #17145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
e84f411 to
305c9c2
Compare
305c9c2 to
a38286d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
dev-packages/e2e-tests/test-applications/hydrogen-react-router-7/package.json
Outdated
Show resolved
Hide resolved
064e912 to
348b4a3
Compare
| project: "example-project", | ||
| // An auth token is required for uploading source maps; | ||
| // store it in an environment variable to keep it secure. | ||
| authToken: process.env.SENTRY_AUTH_TOKEN, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be added to env.d.ts
| /** | ||
| * Export a fetch handler in module format. | ||
| */ | ||
| type Env = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interface is already defined in env.d.ts
| sentryTrace: env.SENTRY_TRACE, | ||
| sentryBaggage: env.SENTRY_BAGGAGE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does env.SENTRY_TRACE and env.SENTRY_BAGGAGE come from? Does wrapRequestHandler from @sentry/cloudflare add this to the env context in server.ts?
Hydrogen switched from Remix v2 to React Router 7 (framework mode) from version
2025.5.0.This PR adds support for React Router 7 (framework) SDK, adding a new entry point for cloudflare environments, and making a few structural changes.
@sentry/react-router/cloudflareentrypoint, similarly to what we have done on@sentry/remix/cloudflare.injectTraceMetaTagsto supportReadableStreamwhich is used instead ofPipeableStream(which we cover ongetMetaTagTransformerfor node environments), on cloudflare environments.Note: Needs documentation update if approved.
closes #17334
closes https://linear.app/getsentry/issue/JS-832/react-router-framework-add-cloudflare-support